From cefdb2b772ce30c840bef1bf3ab5ec2e3900ced7 Mon Sep 17 00:00:00 2001 From: Matias Chomicki Date: Tue, 9 Jul 2024 17:16:28 +0200 Subject: [PATCH 1/2] test(LineFilter): fix test --- src/Components/ServiceScene/LineFilter.test.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Components/ServiceScene/LineFilter.test.tsx b/src/Components/ServiceScene/LineFilter.test.tsx index 87e05979a..4bd81910d 100644 --- a/src/Components/ServiceScene/LineFilter.test.tsx +++ b/src/Components/ServiceScene/LineFilter.test.tsx @@ -1,5 +1,5 @@ import React from 'react'; -import { render, screen } from '@testing-library/react'; +import { act, render, screen } from '@testing-library/react'; import { LineFilter } from './LineFilter'; import userEvent from '@testing-library/user-event'; import { CustomVariable, SceneVariableSet } from '@grafana/scenes'; @@ -26,7 +26,7 @@ describe('LineFilter', () => { test('Updates the variable with the user input', async () => { render(); - await userEvent.type(screen.getByPlaceholderText('Search in log lines'), 'some text'); + await act(() => userEvent.type(screen.getByPlaceholderText('Search in log lines'), 'some text')); expect(await screen.findByDisplayValue('some text')).toBeInTheDocument(); expect(lineFilterVariable.getValue()).toBe('|~ `(?i)some text`'); @@ -35,7 +35,7 @@ describe('LineFilter', () => { test('Escapes the regular expression in the variable', async () => { render(); - await userEvent.type(screen.getByPlaceholderText('Search in log lines'), '(characters'); + await act(() => userEvent.type(screen.getByPlaceholderText('Search in log lines'), '(characters')); expect(await screen.findByDisplayValue('(characters')).toBeInTheDocument(); expect(lineFilterVariable.getValue()).toBe('|~ `(?i)\\(characters`'); From 9a93f7581c8a027a4e136bfd9d4abc0ee01d5d82 Mon Sep 17 00:00:00 2001 From: Matias Chomicki Date: Tue, 9 Jul 2024 17:17:22 +0200 Subject: [PATCH 2/2] test(PatternControls): fix test --- src/Components/IndexScene/PatternControls.test.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Components/IndexScene/PatternControls.test.tsx b/src/Components/IndexScene/PatternControls.test.tsx index 33bc8cc5e..bbe443b85 100644 --- a/src/Components/IndexScene/PatternControls.test.tsx +++ b/src/Components/IndexScene/PatternControls.test.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { PatternControls } from './PatternControls'; -import { render, screen } from '@testing-library/react'; +import { act, render, screen } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { AppliedPattern } from './IndexScene'; @@ -36,7 +36,7 @@ describe('PatternControls', () => { const onRemove = jest.fn(); render(); - await userEvent.click(screen.getByLabelText('Remove pattern')); + await act(() => userEvent.click(screen.getByLabelText('Remove pattern'))); expect(onRemove).toHaveBeenCalledTimes(1); });