Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication introduced in weaveworks/common migration #343

Closed
charleskorn opened this issue Aug 3, 2023 · 0 comments · Fixed by #357
Closed

Reduce duplication introduced in weaveworks/common migration #343

charleskorn opened this issue Aug 3, 2023 · 0 comments · Fixed by #357

Comments

@charleskorn
Copy link
Contributor

From https://github.com/grafana/dskit/pull/342/files/0e1e57319c8c2a483e6f4919a9946a81c017641b#r1283223263:

grpcutil.IsCancelled is kinda duplicative of grpcutil.IsGRPCContextCanceled; do we need both?

And https://github.com/grafana/dskit/pull/342/files/0e1e57319c8c2a483e6f4919a9946a81c017641b#r1283233691:

I think github.com/grafana/dskit/errors.New could be replaced by the Go standard library errors.New.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce duplication introduced in weaveworks/common migration grafana/dskit
1 participant
@charleskorn