From c3627fd32b7d7a3c545b8567b492c1dc832ca8dd Mon Sep 17 00:00:00 2001
From: Marco Pracucci <marco@pracucci.com>
Date: Mon, 20 Sep 2021 14:59:00 +0200
Subject: [PATCH] Add queryEngineConfig

Signed-off-by: Marco Pracucci <marco@pracucci.com>
---
 CHANGELOG.md             | 1 +
 cortex/config.libsonnet  | 7 ++++++-
 cortex/querier.libsonnet | 1 +
 cortex/ruler.libsonnet   | 1 +
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b91a4d0f..7cc30c30 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -57,6 +57,7 @@
   * `CortexAlertmanagerInitialSyncFailed`
 * [ENHANCEMENT] Add support for Azure storage in Alertmanager configuration. #381
 * [ENHANCEMENT] Add support for running Alertmanager in sharding mode. #394
+* [ENHANCEMENT] Allow to customize PromQL engine settings via `queryEngineConfig`. #399
 * [BUGFIX] Fixed `CortexIngesterHasNotShippedBlocks` alert false positive in case an ingester instance had ingested samples in the past, then no traffic was received for a long period and then it started receiving samples again. #308
 * [BUGFIX] Alertmanager: fixed `--alertmanager.cluster.peers` CLI flag passed to alertmanager when HA is enabled. #329
 * [BUGFIX] Fixed `CortexInconsistentRuntimeConfig` metric. #335
diff --git a/cortex/config.libsonnet b/cortex/config.libsonnet
index 5187b841..fdb8bbb0 100644
--- a/cortex/config.libsonnet
+++ b/cortex/config.libsonnet
@@ -196,7 +196,7 @@
       ) else {}
     ),
 
-    // Shared between the Ruler and Querier
+    // Querier component config (shared between the ruler and querier).
     queryConfig: {
       'runtime-config.file': '/etc/cortex/overrides.yaml',
 
@@ -239,6 +239,11 @@
       else {}
     ),
 
+    // PromQL query engine config (shared between all services running PromQL engine, like the ruler and querier).
+    queryEngineConfig: {
+      // Keep it even if empty, to allow downstream projects to easily configure it.
+    },
+
     ringConfig: {
       'consul.hostname': 'consul.%s.svc.cluster.local:8500' % $._config.namespace,
       'ring.prefix': '',
diff --git a/cortex/querier.libsonnet b/cortex/querier.libsonnet
index 664c759b..2ec8d868 100644
--- a/cortex/querier.libsonnet
+++ b/cortex/querier.libsonnet
@@ -8,6 +8,7 @@
     $._config.storageConfig +
     $._config.blocksStorageConfig +
     $._config.queryConfig +
+    $._config.queryEngineConfig +
     $._config.distributorConfig +
     {
       target: 'querier',
diff --git a/cortex/ruler.libsonnet b/cortex/ruler.libsonnet
index 6fbed6bc..1e982820 100644
--- a/cortex/ruler.libsonnet
+++ b/cortex/ruler.libsonnet
@@ -8,6 +8,7 @@
     $._config.storageConfig +
     $._config.blocksStorageConfig +
     $._config.queryConfig +
+    $._config.queryEngineConfig +
     $._config.distributorConfig +
     $._config.rulerClientConfig +
     $._config.rulerLimitsConfig +