You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
log.Printf("Error listening and serving: %s", err)
os.Exit(1)
}
The implications is that if k8s decides to shutdown the application mid scrape, the process will just shutdown before the scrape can finish. We should add a signal handler that listens for sigterm and sigexit signals and propagate the cancel through the contexts. If you're not familiar with this, check out this stackoverflow answer: https://stackoverflow.com/a/40041517
The text was updated successfully, but these errors were encountered:
In the exporter.go, we launch our webserver and do not gracefully handle shutdowns:
cloudcost-exporter/cmd/exporter/exporter.go
Lines 90 to 93 in 04122bb
The implications is that if k8s decides to shutdown the application mid scrape, the process will just shutdown before the scrape can finish. We should add a signal handler that listens for sigterm and sigexit signals and propagate the cancel through the contexts. If you're not familiar with this, check out this stackoverflow answer: https://stackoverflow.com/a/40041517
The text was updated successfully, but these errors were encountered: