Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrosope.scrape, pyroscope.write: clarify dropped labels behavior #2629

Closed
korniltsev opened this issue Feb 6, 2025 · 1 comment · Fixed by #2710
Closed

pyrosope.scrape, pyroscope.write: clarify dropped labels behavior #2629

korniltsev opened this issue Feb 6, 2025 · 1 comment · Fixed by #2710
Assignees
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components bug Something isn't working documentation Improvements or additions to documentation frozen-due-to-age

Comments

@korniltsev
Copy link
Contributor

pyroscope.scrape drops all meta labels ( starts with __meta_* )
pyroscope.write drops all private labels (starts with __) , except __name__ and __delta__

Both dropping logic is not documented and an implementation detail.

With the new pyroscope.relabel component, it may be useful in some cases to NOT drop meta labels, so that they can be used in pyroscope.relabel component.

I think we should do one of the following:

  • document that pyroscope.scrape drops meta labels
  • make the pyroscope.scrape not drop labels

Maybe we should also document pyroscope.write behavior as well

@korniltsev korniltsev added the bug Something isn't working label Feb 6, 2025
@korniltsev korniltsev self-assigned this Feb 6, 2025
@korniltsev korniltsev added documentation Improvements or additions to documentation area/pyroscope Issues/PRs primarly affecting `pyroscope.` components labels Feb 6, 2025
@korniltsev
Copy link
Contributor Author

cc @marcsanmi @simonswine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components bug Something isn't working documentation Improvements or additions to documentation frozen-due-to-age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant