Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope.receive_http treats headers inconsistently #2612

Open
simonswine opened this issue Feb 4, 2025 · 0 comments
Open

pyroscope.receive_http treats headers inconsistently #2612

simonswine opened this issue Feb 4, 2025 · 0 comments
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components

Comments

@simonswine
Copy link
Contributor

pyroscope.receive_http supports forwarding pushv1 and ingest handler.

For the pushv1 non of the headers are forwarded, while the ingest handler forwards all but a block list of headers:

https://github.com/simonswine/alloy/blob/755bcfcb5ab193488a226f467216b93ce98c6cd1/internal/component/pyroscope/write/write.go#L45-L52

I suggest we should only forward headers, that are important for parsing of the profiles, which includes:

@simonswine simonswine changed the title pyroscope.receive_http treats headers in consistentl pushv1 support the connect go handlers pyroscope.receive_http treats headers inconsistently Feb 4, 2025
@simonswine simonswine added the area/pyroscope Issues/PRs primarly affecting `pyroscope.` components label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pyroscope Issues/PRs primarly affecting `pyroscope.` components
Projects
None yet
Development

No branches or pull requests

1 participant