This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Let getting property delegate use getByName() instead of named()
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamboo
force-pushed
the
bamboo/let-getting-use-getByName
branch
from
7a5e7a0 to
a980838
Compare
|
Have there been reports of users finding this to be confusing as it was before? |
|
@JLLeitschuh yes, it was surprising and caused confusion in knowing what is eager and what is lazy. |
eskatos
changed the title
getting property delegate use getByName instead of namedgetting property delegate use getByName() instead of named()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize confusion when migrating away from the eager API.