Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Reduce code generation overhead #1202

Closed
bamboo opened this issue Oct 23, 2018 · 2 comments
Closed

Reduce code generation overhead #1202

bamboo opened this issue Oct 23, 2018 · 2 comments
Assignees
@bamboo
Labels
a:feature in:kotlin-dsl-runtime re:performance
Milestone
1.0.4

Comments

@bamboo
Copy link
Member

bamboo commented Oct 23, 2018

Each code generator use one separate short-lived IO thread per project which in the worst case (first-use no cache) leads to the creation of at least one thread per project in a multi-project and two for the root project.

Follow up to #1199
@bamboo bamboo added this to the 1.0.1 milestone Oct 23, 2018
@JLLeitschuh
Copy link
Contributor

Could coroutines help here?

Also, in my project this will result in something like 70 thread being created, for the core Gradle project, it will be 85 threads.

@eskatos eskatos modified the milestones: 1.0.1, 1.1.0 Oct 26, 2018
@bamboo bamboo self-assigned this Nov 8, 2018
bamboo added a commit that referenced this issue Nov 12, 2018
@bamboo
Use a single IO thread per build
f9748d7 
And let it be managed  by Gradle's `ExecutorFactory` service.

See #1202
@bamboo bamboo mentioned this issue Nov 12, 2018
Merged
@bamboo
Copy link
Member Author

bamboo commented Nov 13, 2018

Implemented by #1245.

@bamboo bamboo closed this as completed Nov 13, 2018
@eskatos eskatos modified the milestones: 1.1.0, 1.0.4 Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bamboo bamboo

Labels
a:feature in:kotlin-dsl-runtime re:performance
Projects
None yet
Milestone
1.0.4
Development

No branches or pull requests
3 participants
@bamboo @eskatos @JLLeitschuh