This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Generate compilable accessors for container elements of default package type #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskatos
reviewed
Oct 9, 2018
...s/src/test/kotlin/org/gradle/kotlin/dsl/integration/ProjectSchemaAccessorsIntegrationTest.kt
Outdated
Show resolved
Hide resolved
JLLeitschuh
reviewed
Oct 9, 2018
| @@ -32,4 +34,29 @@ class DefaultPackageTypesTest { | |||
| equalTo(listOf("Extension")) | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `#importsRequiredBy takes container elements into account`() { | |||
There was a problem hiding this comment.
❓ What's the significance of the # symbol in the test name?
There was a problem hiding this comment.
That's meant to signify the name refers to a function (like in javadoc links).
eskatos
suggested changes
Oct 10, 2018
...s/src/test/kotlin/org/gradle/kotlin/dsl/integration/ProjectSchemaAccessorsIntegrationTest.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Merlin <[email protected]>
eskatos
approved these changes
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.