This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Upgrade to Kotlin 1.3 #1125
Merged
Upgrade to Kotlin 1.3 #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until a new version of `kotlin-dsl` is published.
Because the `kotlin.script` classes required by the `kotlin-dsl` were moved there.
This reverts commit 5d9d054.
To silence IntelliJ warning about it.
Broken after the latest upgrade to Gradle master.
|
@eskatos, this is ready for your review. There are 2 open issues:
|
eskatos
suggested changes
Sep 21, 2018
There was a problem hiding this comment.
Upgrade went not so bad 👍
I requested one change about the kotlin-eap repository.
Let's see if @lptr has some light to shed on us about the Groovy 2.5 FastString issue with ProjectBuilder.
Did you find an existing issue about the kapt problem?
| kotlin { | ||
| experimental.coroutines = Coroutines.ENABLE | ||
| } | ||
|
|
subprojects/provider/src/main/kotlin/org/gradle/kotlin/dsl/provider/KotlinScriptEvaluator.kt
Outdated
Show resolved
Hide resolved
eskatos
approved these changes
Sep 21, 2018
Now that the upgrade to Kotlin 1.3.0-rc-57 is complete.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Kotlin to the latest EAP release
1.3-rc-57and automatically add thekotlinEap()repository to every project'sbuildscript.repositoriesandrepositoriesto ease migration.