This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Fix missing parameter names in Gradle Kotlin DSL jars #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
and use that to build `gradle/kotlin-dsl` artifacts Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
Signed-off-by: Paul Merlin <[email protected]>
With the added artifact transform, the size of snapshoting caches went up, hitting the previous conservative limit of 256m. Signed-off-by: Paul Merlin <[email protected]>
by removing duplicated code and leveraging transform parameters to simplify locating the api metadata jar Signed-off-by: Paul Merlin <[email protected]>
- rename method for clarity - extract explaining methods - tighten members visibility Signed-off-by: Paul Merlin <[email protected]>
0 should be fine Signed-off-by: Paul Merlin <[email protected]>
bamboo
reviewed
Aug 4, 2018
| @@ -46,6 +46,8 @@ annotation class KotlinScriptTemplate | |||
| resolver = KotlinBuildScriptDependenciesResolver::class, | |||
| scriptFilePattern = ".*\\.gradle\\.kts") | |||
| @ScriptTemplateAdditionalCompilerArguments([ | |||
| "-java-parameters", | |||
There was a problem hiding this comment.
❓ I don't understand why the new compiler options are also required in the script templates. I understood -Xuse-old-class-files-reading was required to get the compiler to load parameter names from the transformed Gradle api jar and -java-parameters was about preserving parameter names in the emitted class files, none of which seem to apply to the scripts, what am I missing?
There was a problem hiding this comment.
Right. I've been overzealous. We don't need those for script compilation. And we don't need -Xuse-old-class-files-reading on the kotlin-dsl plugin.
and from IDE script templates Signed-off-by: Paul Merlin <[email protected]>
…lation and from IDE script templates and from kotlin-dsl plugin Signed-off-by: Paul Merlin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions on types using kotlin implementation by delegation for a Java interface miss parameter names metadata.
See #464
Reusing the
gradle-api-metadata, anArtifactTransformhydrates the Gradle API bytecode provided bygradleApi()with Java 8 parameter names. The Gradle Kotlin DSL is compiled against the transformed Gradle API disabling the kotlin compiler fast class reader. This combination lets the parameter names show up properly in the IDE instead ofp0,p1...