Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Audio/Sound alert when a job is complete #2173

Closed
1 task done
nelsonjchen opened this issue Sep 3, 2022 · 4 comments · Fixed by #2478
Closed
1 task done

Optional Audio/Sound alert when a job is complete #2173

nelsonjchen opened this issue Sep 3, 2022 · 4 comments · Fixed by #2478
Labels
enhancement New feature or request
Milestone

Comments

@nelsonjchen
Copy link

  • I have searched to see if a similar issue already exists.

Is your feature request related to a problem? Please describe.
I frequently go browse other tabs or applications when I am running a long running batch of jobs. Sometimes I fall into a hole and take a bit longer than expected to get back to the tab. If I stay in the research hole a bit too long, my hardware is idle when it could be working on jobs batches. I want to maximize utilization of my hardware, iterate more, and the limiter is me.

Describe the solution you'd like
I would like some sort of optional audio/sound notification to be played when generation is complete so I know to return to the UI, evaluate the results, tinker, and kickoff the next batch. This should help keep my hardware working and help increase output and utilization.

I don't know Gradio's API that well to be honest and this may very well be implementable downstream as a Gradio consumer without upstream support. I do know that if the functionality is implemented upstream and is turnkey that downstream Gradio users are more likely to implement and turn on a pre-existing turnkey audio/sound alert solution. I do see a lot more Gradio in my future.

Additional context
I have a more specific version of this request here for the hlky/stable-diffusion's gradio implementation: Sygil-Dev/sygil-webui#232

I figure it might be a good idea to get this idea upstream so that maybe it can flow back downstream someday. I believe it to be a pretty generic idea that isn't specific to my use case and is applicable to other uses as well.

I do have a suggestion for a default sound which I don't think should kick off anyone's tinnitus: https://freesound.org/people/collierhs_colinlib/sounds/588718/

It reminds me of the buckle your seatbelt sign/turbulence for passengers warning on an airplane for some reason.

@abidlabs
Copy link
Member

abidlabs commented Sep 5, 2022

I really like this suggestion!

@nelsonjchen
Copy link
Author

nelsonjchen commented Sep 28, 2022

AUTOMATIC1111/stable-diffusion-webui#1126

This was added to the AUTOMATIC1111 SD UI.

The code doesn't look heavy. Still would love more proliferation. Maybe throw something similar into some samples/documentation?

@freddyaboulton
Copy link
Collaborator

Very cool @nelsonjchen !

@abidlabs
Copy link
Member

Great @nelsonjchen! Yes we can add this as a demo people can refer to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants