This repository was archived by the owner on Feb 12, 2025. It is now read-only.
fix: better understanding of staleTime and cacheTime
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
force-pushed
the
no-cachetime-for-item-thumbnail
branch
from
2c96c0c to
871a6b8
Compare
spaenleh
added
bug 🪲
ReidyT
approved these changes
Jan 26, 2024
pyphilia
approved these changes
Jan 29, 2024
Co-authored-by: Kim Lan Phan Hoang <[email protected]>
spaenleh
force-pushed
the
no-cachetime-for-item-thumbnail
branch
from
c6d9821 to
e49ad9b
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the docs more carefully, there was a miss-understanding in the use of
staleTimeandcacheTime.So for our application we want:
staleTimethat represents our usual loading time, or until all components have rendered on screen and we would like to minimise the number of duplicated request to the backend. Ideally only one per resource.cacheTimethat is big enough so that when navigating between pages we can display the "old" data before updating it -> this will remove a lot of loading spinners once we have data (even if it is slightly older).Proposed default values:
staleTime: 3 secondscacheTime: 5 minutes (this is the default for react query)Understanding this difference we should change
Constant cache timeto actually be aConstant stale timefor rarely updated data (thumbnails, app list, and others)