Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

feat: library profile mutations #514

Merged
merged 14 commits into from
Dec 8, 2023
Merged

feat: library profile mutations #514

merged 14 commits into from
Dec 8, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Nov 7, 2023 •
edited
Loading

closes #510

@LinaYahya LinaYahya marked this pull request as ready for review November 9, 2023 13:26
pyphilia
pyphilia suggested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's not call it libraryProfile not memberProfile --> What about publicProfile?
Let me know if you have more suggestions! 🍃

@LinaYahya LinaYahya requested a review from pyphilia November 15, 2023 15:11
pyphilia
pyphilia suggested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, let's be consistent with the naming a bit more 😉
Don't hesitate to resolve discussions when you apply the changes, so I know what should be discussed + you know what you did or not.

@LinaYahya LinaYahya requested a review from pyphilia November 27, 2023 10:43
pyphilia
pyphilia suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed for the translations!

@LinaYahya LinaYahya requested a review from pyphilia December 4, 2023 10:50
pyphilia
pyphilia approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this PR!

@LinaYahya LinaYahya merged commit 353664e into main Dec 8, 2023
@LinaYahya LinaYahya self-assigned this Dec 8, 2023
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@spaenleh spaenleh deleted the 510-library-profile-mutations branch January 22, 2024 15:06
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh Awaiting requested review from spaenleh

Assignees

@LinaYahya LinaYahya

Labels
v2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create library profile hooks and mutations
2 participants
@LinaYahya @pyphilia