Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

fix: use ThumbnailSize from sdk #252

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Mar 8, 2023

This PR uses ThumbnailSizes defined in sdk instead of own constant

closes #251

@spaenleh spaenleh linked an issue Mar 8, 2023 that may be closed by this pull request
@spaenleh spaenleh added bug 🪲 Something isn't working improvement Not a feature but a QoL improvement in DX labels Mar 8, 2023
@spaenleh spaenleh self-assigned this Mar 8, 2023
@spaenleh spaenleh requested review from codeofmochi and pyphilia March 8, 2023 15:08
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice 🌴

Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a question regarding tsconfig 🤔

@spaenleh spaenleh merged commit 58941fe into main Mar 9, 2023
@spaenleh spaenleh deleted the 251-use-thumbnailsize-from-sdk branch March 9, 2023 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working improvement Not a feature but a QoL improvement in DX v0.3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ThumbnailSize from sdk
3 participants