Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

feat: add qr share link to share an item #797

Merged
merged 7 commits into from
Oct 2, 2023
Merged

feat: add qr share link to share an item #797

merged 7 commits into from
Oct 2, 2023

Conversation

LinaYahya
Copy link
Contributor

@LinaYahya LinaYahya commented Sep 20, 2023 •
edited
Loading

add QR code to link sharing as follows

  • having an icon of QR code
    Screenshot from 2023-09-20 13-15-59

  • open a modal of the generated QR Code
    Screenshot from 2023-09-20 13-16-11

closes #319

@LinaYahya LinaYahya requested a review from pyphilia September 20, 2023 11:17
@LinaYahya LinaYahya self-assigned this Sep 20, 2023
pyphilia
pyphilia suggested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I'm not quite sure about showing a bare modal with only the QR code, tho I can see the purpose of showing it big and alone. Most probably in the future we can extend the modal with a export as png button, etc.

@LinaYahya LinaYahya requested a review from pyphilia September 26, 2023 07:59
pyphilia
pyphilia previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment + it would be nice to have one test that click on this QR button and check the modal does open.

@LinaYahya LinaYahya requested a review from spaenleh October 2, 2023 10:18
spaenleh
spaenleh suggested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗳️ Nice changes ! Just a few comments and it is good to go.

@LinaYahya LinaYahya requested a review from spaenleh October 2, 2023 12:40
@spaenleh spaenleh dismissed pyphilia’s stale review October 2, 2023 12:48

Outdated review

@LinaYahya LinaYahya merged commit 046bc5e into main Oct 2, 2023
@github-actions github-actions bot mentioned this pull request Oct 2, 2023
Merged
@spaenleh spaenleh deleted the 319-qr-item-share-link branch October 4, 2023 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@pyphilia pyphilia pyphilia left review comments

Assignees

@LinaYahya LinaYahya

Labels
v1.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate QR codes for item's link
3 participants
@LinaYahya @pyphilia @spaenleh