This repository was archived by the owner on Jan 23, 2025. It is now read-only.
feat: add document styles in Builder #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
codeofmochi
changed the title
codeofmochi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509
Implements document styles (as Alert components).
This PR also refactors
ItemContentwith better typing: the item is first checked against its typed, and each item type now has a corresponding content component. This allows only invoking hooks only when they are actually needed, and the item extras are now correctly typed according to their discriminated union type (thanks to @spaenleh's work). It also provides cleaner loading and error handling logic, since they are scoped to however the item type behaves / fails.Kapture.2023-02-20.at.17.01.18.webm