This repository was archived by the owner on Jan 23, 2025. It is now read-only.
feat: show delete item login schema alert to permanently remove data #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
suggested changes
Nov 25, 2024
There was a problem hiding this comment.
The code looks good 🧑🚀
I just have two remarks concerning the UI:
- I would place the alert between the visibility selector (private, ...) and the "Rendre visible pour les lecteurs".
- I would center vertically the delete bouton.
I'm of course open to the discussion ^^
cypress/e2e/item/authorization/itemLogin/itemLoginSetting.cy.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLoginSetting.cy.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/item/authorization/itemLogin/itemLoginSetting.cy.ts
Outdated
Show resolved
Hide resolved
pyphilia
force-pushed
the
1576-delete-item-login
branch
from
fdcdb37 to
aa15249
Compare
ReidyT
approved these changes
Nov 26, 2024
pyphilia
force-pushed
the
1576-delete-item-login
branch
from
aa15249 to
9b25746
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-22.at.11.02.28.mov
Screen.Recording.2024-11-22.at.10.52.42.mov
Screen.Recording.2024-11-22.at.10.51.59.mov
close #1576