Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

fix: show request membership only for forbidden access #1507

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 7, 2024

fix #1506

question: maybe we want to show item not found 404 for the other cases? instead of showing cannot have access?

@pyphilia pyphilia requested review from spaenleh and ReidyT October 7, 2024 16:20
@pyphilia pyphilia self-assigned this Oct 7, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌝

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just adapt the comments.

@pyphilia pyphilia enabled auto-merge October 9, 2024 10:04
Copy link

sonarqubecloud bot commented Oct 9, 2024

@pyphilia pyphilia added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit a900c25 Oct 9, 2024
4 checks passed
@spaenleh spaenleh deleted the 1506-fix-request-im-forbidden branch October 14, 2024 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show request membership for ITEM_NOT_FOUND
3 participants