Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

feat: add umami tags to track actions #1500

Merged
merged 7 commits into from
Oct 9, 2024
Merged

feat: add umami tags to track actions #1500

merged 7 commits into from
Oct 9, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Oct 3, 2024

In this PR:

  • add umami script
  • add umami events on the home page

Still todo is graasp/client#628

Umami-events (1)

closes #1495

@spaenleh spaenleh requested review from pyphilia and ReidyT October 3, 2024 17:18
@spaenleh spaenleh self-assigned this Oct 3, 2024
@spaenleh spaenleh added the feature New feature or request label Oct 3, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! Let me know what you think of my suggestion.
I think event-page should be always returned?

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, I would use dataUmamiEvent it's more precise.

@spaenleh spaenleh enabled auto-merge October 9, 2024 13:50
@spaenleh spaenleh added this pull request to the merge queue Oct 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 9, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

@spaenleh spaenleh merged commit 263a08a into main Oct 9, 2024
4 checks passed
@spaenleh spaenleh deleted the 1495-umami branch October 9, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request v2.43.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Umami for tracking
2 participants