This repository was archived by the owner on Jan 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add multi op for home, recycle bin, folder screens #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaenleh
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the work !
ReidyT
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this very nice PR! LGTM, I just let some comments 😶🌫️
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added back a toolbar that shows when at least one item is selected.
One can select an item by clicking on the thumbnail (originally all the card, but I add conflicts with the op buttons on the right (menu item, bookmark, etc)) so I fallbacked to the thumbnail only.
We can also drag-select many items. There's no cmd/ctrl functionality (yet).
Features:
Not in this PR: we cannot reorder many items
TODO
Screen.Recording.2024-07-22.at.15.06.29.mov
Screen.Recording.2024-07-22.at.15.05.40.mov
Screen.Recording.2024-07-22.at.15.04.58.mov
close #1342