This repository was archived by the owner on Jan 23, 2025. It is now read-only.
feat: add geolocation modal #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pyphilia
commented
Mar 25, 2024
pyphilia
commented
pyphilia
force-pushed
the
secondary-address
branch
from
a77856c to
dcbd664
Compare
spaenleh
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thank you for this PR.
Would it make sens to put the country dropdown before the address ? so we can go from less specific to most specific ?
Can users input only lat+long or the address ? How can we make it clear that it is an OR choice and that the other parts will get autofilled (if that is the case) ?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
ztlee042
pushed a commit
that referenced
this pull request
Apr 4, 2024
* refactor: add geolocation modal * refactor: add translations * refactor: update fr trans * refactor: upgrade query client
spaenleh
pushed a commit
that referenced
this pull request
Apr 5, 2024
* refactor: add geolocation modal * refactor: add translations * refactor: update fr trans * refactor: upgrade query client
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
* feat: modify 'add text' title text * feat: add helper text * Revert "feat: modify 'add text' title text" This reverts commit 8d34688. * feat: change 'add text' title * feat: add helper text in NameForm * feat: change 'add text' tab text * feat: change 'add text' title style * feat: add clear button to name form * feat: add display name form * feat: change helper text wording * feat: autocomplete displayName * feat: change document form ui * feat: add tests * fix: update comment Co-authored-by: Basile Spaenlehauer <[email protected]> * fix: update DocumentForm Co-authored-by: Basile Spaenlehauer <[email protected]> * fix: update yarn.lock * fix: code matches * feat: change document form select styles * fix: add comment * fix: menu item background color * fix: helper text and style * feat: add tooltip * fix: disable DisplayNameForm autofocus * feat: add geolocation modal (#1112) * refactor: add geolocation modal * refactor: add translations * refactor: update fr trans * refactor: upgrade query client * fix: update yarn.lock * feat: update yarn.lock * fix: add select of flavors * fix: update styles * fix: display name was erased in edit * fix: make new item modal the same and udpate deps * fix: update deps * fix: remove semi-colon --------- Co-authored-by: Basile Spaenlehauer <[email protected]> Co-authored-by: Kim Lan Phan Hoang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.