Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wgslLanguageFeatures test #4139

Closed
sagudev opened this issue Jan 10, 2025 · 3 comments
Closed

Add wgslLanguageFeatures test #4139

sagudev opened this issue Jan 10, 2025 · 3 comments
Assignees

Comments

@sagudev
Copy link
Collaborator

sagudev commented Jan 10, 2025

test that returned object is same object (is this done as part of idl tests?)

@kainino0x
Copy link
Collaborator

It could go anywhere honestly, either under IDL tests or wherever the other SameObject tests (for adapter.info, etc.) are.

There are no autogenerated IDL tests or anything, so if there isn't a manually written test, none exists.

@greggman
Copy link
Contributor

greggman commented Feb 4, 2025

added. #4175

Ok to close?

@sagudev
Copy link
Collaborator Author

sagudev commented Feb 5, 2025

added. #4175

Ok to close?

Yes, I just tested.

BTW there is webgpu:api,operation,device,lost:same_object:* and webgpu:api,operation,adapter,info:same_object:*, but only last one is also done in webgpu:idl,javascript:sameObject:*, so we got missing test and duplication.

@sagudev sagudev closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants