Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: fract tests unexpectedly ballooning runtime #3701

Closed
zoddicus opened this issue Apr 23, 2024 · 2 comments
Closed

wgsl: fract tests unexpectedly ballooning runtime #3701

zoddicus opened this issue Apr 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working wgsl

Comments

@zoddicus
Copy link
Contributor

I recently did some refactoring of the AF fract code to use a lookup table of values. Unexpectedly this appears to have ballooned the runtime of all fract tests. Tint has been forced to suppress them due to timeouts, https://dawn-review.googlesource.com/c/dawn/+/185183.

There were already existing AF fract tests, so this isn't a case of just adding more slow tests. Additionally the f32 and f16 tests appear to be slow too.

I suspect this is related to all the lookup data being stored in a single file, af_data.ts and so fract is paying costs associated with the other look up tables. I am going to attempt to refactor the tables into seperate files and see if that resolves the issue. If that isn't successful I will have to investigate further.

@zoddicus zoddicus added bug Something isn't working wgsl labels Apr 23, 2024
@zoddicus zoddicus self-assigned this Apr 23, 2024
@kainino0x
Copy link
Collaborator

It sounded like this was probably just due to #3702, is it fixed now?

@zoddicus
Copy link
Contributor Author

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wgsl
Projects
None yet
Development

No branches or pull requests

2 participants