Add option for mergeTrees configuration, fixes #32 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gdub22 what do you think? |
|
@knownasilya you're call. I'd say it'd be better if we could somehow automatically do this for the user, otherwise just update the readme that you have to add the override if you want custom outputPaths. Seems like a regression somewhere else? |
Since it's basically required for now.
|
Probably worthwhile adding it in the mean time. Even if it is a regression, it might take a while to fix it, plus this option might be useful for something else. We could always deprecate it, and then remove in the next major version if it is a regression and it's fixed. |
knownasilya
pushed a commit
that referenced
this pull request
Oct 13, 2015
Add option for mergeTrees configuration, fixes #32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically expose the options for the internal merge trees plugin.
Related to #32