Skip to content
This repository was archived by the owner on Dec 24, 2017. It is now read-only.

Question #1

Open
usb248 opened this issue Jul 16, 2015 · 5 comments
Open

Question #1

usb248 opened this issue Jul 16, 2015 · 5 comments

Comments

@usb248
Copy link

usb248 commented Jul 16, 2015

Hi,

Your plugin is just perfect ! Exactly what i search. (This similar plugin give the same functionality https://github.com/somewebmedia/hc-sticky with more features.)

In your doc, you don't write what is the compatibility with browser (IE version, mobile device etc ...?)

It will be very interesting if your add callback and few "command" like this :

stop : Stops the sticky while preserving its current position.
off :Turnes off the sticky completely.
on :Turns the sticky back on after above two commands.
reinit :Recalculates sticky size. Useful after altering DOM elements inside sticky.
destroy :Completely destroys sticky and reverts element to original state.

Thanks !

@gotbahn
Copy link
Owner

gotbahn commented Jul 16, 2015

@usb248 thank you for feedback and proposals

In your doc, you don't write what is the compatibility with browser (IE version, mobile device etc ...?)

My missing, updated this info in README.md

It will be very interesting if your add callback and few "command" like this :

stop : Stops the sticky while preserving its current position.
off :Turnes off the sticky completely.
on :Turns the sticky back on after above two commands.
reinit :Recalculates sticky size. Useful after altering DOM elements inside sticky.
destroy :Completely destroys sticky and reverts element to original state.

Good point, will think about additional functionality for next release, added ticket for myself.
Btw if you want to speed up process and contribute some of this features, you are welcome.

@usb248
Copy link
Author

usb248 commented Jul 16, 2015

Yes thanks, if i have time. Why not.

On tablet/mobile the scroll event is not fired continuously like it is on desktop. It is fired only when the scroll actually ends.
The resulting behaviour is that the element does not reposition immediately, but just at the end of the scroll.

Have you detect this little bug (I tested on my android phone (HTC One mini), firefox browser render with this no good behaviour ... ) ?

@gotbahn
Copy link
Owner

gotbahn commented Jul 16, 2015

@usb248 yeah, saw this, sometimes u even need to do additional scroll to make fixes element stay in right position.

Didn't think about solution, rarely sidebar stays sidebar on mobile. Need to investigate this, thanks.

@usb248
Copy link
Author

usb248 commented Jul 16, 2015

Yes rarely on mobile device but often on tablet.

Maybe a track link

@gotbahn
Copy link
Owner

gotbahn commented Jul 16, 2015

@usb248 added bug ticket

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants