Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous navigation of tracks seems broken #1043

Closed
sehilyi opened this issue Feb 22, 2024 · 1 comment · Fixed by #1044
Closed

Synchronous navigation of tracks seems broken #1043

sehilyi opened this issue Feb 22, 2024 · 1 comment · Fixed by #1044
Labels
bug🐛 Something isn't working

Comments

@sehilyi
Copy link
Member

sehilyi commented Feb 22, 2024

I found the issue in the GIVE example on the Editor (https://gosling.js.org/?example=GIVE) and also in the Gosling Designer that uses the most recent Gosling version.

I can reproduce this by zooming in (e.g., seeing a few hundred BPs), panning, and then zooming out quickly.

Screen.Recording.2024-02-22.at.8.48.26.AM.mov

I see the following error message:

Screenshot 2024-02-22 at 8 55 24 AM

Copied texts:

index-fdb53256.js:1668 Uncaught RangeError: Maximum call stack size exceeded
    at new MJt (index-fdb53256.js:1668:1241331)
    at index-fdb53256.js:1668:1264625
    at Array.forEach (<anonymous>)
    at _e.transformDataAndCreateModels (index-fdb53256.js:1668:1263708)
    at index-fdb53256.js:1668:1259473
    at Array.flatMap (<anonymous>)
    at _e.processAllTiles (index-fdb53256.js:1668:1259456)
    at Ie (index-fdb53256.js:1668:1256496)
    at _e.draw (index-fdb53256.js:1668:1256723)
    at _e.zoomed (index-fdb53256.js:1668:1258755)

The maximum call stack error is coming from the following code:

this.specComplete = structuredClone(spec);

@sehilyi sehilyi added the bug🐛 Something isn't working label Feb 22, 2024
@etowahadams
Copy link
Contributor

Interesting! That line was added in this PR. I'll look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants