bug found in model search

[konukk]

master branch，master/master.go

// SearchLoop searches optimal recommendation model in background. It never modifies variables other than
// rankingModelSearcher, clickSearchedModel and clickSearchedScore.
func (m *Master) SearchLoop() {
	defer base.CheckPanic()
	lastNumUsers, lastNumItems, lastNumFeedback := 0, 0, 0
	for {
		var trainSet, valSet *ranking.DataSet
		// download dataset
		base.Logger().Info("load dataset for model search", zap.Strings("feedback_types", m.GorseConfig.Database.PositiveFeedbackType))
		dataSet, _, _, err := ranking.LoadDataFromDatabase(m.DataClient, m.GorseConfig.Database.PositiveFeedbackType,
			m.GorseConfig.Database.ItemTTL, m.GorseConfig.Database.PositiveFeedbackTTL)
		if err != nil {
			base.Logger().Error("failed to load database", zap.Error(err))
			goto sleep
		}
		// sleep if empty
		if dataSet.Count() == 0 {
			base.Logger().Warn("empty dataset", zap.Strings("feedback_type", m.GorseConfig.Database.PositiveFeedbackType))
			goto sleep
		}
		// sleep if nothing changed
		if dataSet.UserCount() == lastNumUsers && dataSet.ItemCount() == lastNumItems && dataSet.Count() == lastNumFeedback {
			goto sleep
		}
		// start search ranking model
		trainSet, valSet = dataSet.Split(0, 0)
		err = m.rankingModelSearcher.Fit(trainSet, valSet)
		if err != nil {
			base.Logger().Error("failed to search ranking model", zap.Error(err))
		}
		// start search click model
		err = m.searchClickModel()
		if err != nil {
			base.Logger().Error("failed to search click model", zap.Error(err))
		}
	sleep:
		time.Sleep(time.Duration(m.GorseConfig.Recommend.SearchPeriod) * time.Minute)
	}
}

lastNumUsers, lastNumItems, lastNumFeedback always zero

[zhenghaoz]

Thanks😁