-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"|https://$third-party,image" uBlock incorrect reading #1548
Comments
http://repo.a2af37vnxe44tcgo.onion/data/abl/nm_fanboy-ultimate.txt contains this filter:
|
First of all, if you use the "NoMercy" lists, which strip out the exception rules that keep certain sites from breaking, you'll have a bad time: https://adblockplus.org/forum/viewtopic.php?p=120975#p120975 With that said, I haven't found a no-Tor mirror of those filter lists, so I went ahead and fired up the Tor Browser just to look at them, and in the "NoMercy" version of Fanboy Ultimate, I found this gem:
I found that same filter, in the same place, in the "NoMercy" version of EasyList Asia. The real question, then, is how that filter got in there, and why uBlock Origin reports the filter as something else (maybe the latter has to do with how it decomposes the filter options and internally represents the filter). Around that same spot in EasyList itself (the part about adult-specific blocking), I see a very similar filter, but with negative domain specifiers:
Both of these variants were right above the following filter, so I highly believe that the first one is the second with its negative domain specifier removed:
Below are the two NoMercy lists as of a few minutes ago, and below that is EasyList as of that time: |
Yes. |
He already answered that question above.
|
uBO decomposes filters in smaller units, for efficiency purpose, and to detect/discard duplicates.
In the logger, the textual representation of the filter involved in a network request is rebuilt using it's decomposed version. See https://github.com/gorhill/uBlock/wiki/Launch-and-filter-lists-load-performance. |
reportingnow commented Apr 8, 2016
uBlock enforce "|https://$third-party,image" blocking rule even the blocklist
have nothing such line.
One or more specific URLs where the issue occurs
https://www.amazon.co.jp/
(not http://)
Screenshot in which the issue can be seen
https://i.imgur.com/3GoQl3J.jpg
Steps for anyone to reproduce the issue
Your settings
Your filter lists
Only these; other lists are not checked.
http://repo.a2af37vnxe44tcgo.onion/data/abl/nm_fanboy-ultimate.txt
http://repo.a2af37vnxe44tcgo.onion/data/abl/nm_easylist_asia.txt
Your custom filters (if any)
none.
This is NOT blocklist's fault; Adblock works fine.
reportingnow commented Apr 8, 2016
Current data, for @gorhill. See, there's no "|https://$third-party,image".
What do you think? Why uBlock Origin think "|https://$third-party,image" is exist?
reportingnow commented Apr 8, 2016
https://gist.github.com/reportingnow/4f7ff270bd4053a10fba19a1461b4c4d
The text was updated successfully, but these errors were encountered: