Getting empty strings for content

[SunnyRaj]

How have you installed gord

• go get
• Github Releases
• git clone & go build .

What happened

The content is being rendered/obtained as an empty string.

Error output

The history of the messages and the content of any replies are showing fine, the main message/content is empty.

How do you reproduce this bug

Build and Run normally as you would and observe any channel.

System information

Key	Value
OS	Mac OS
Architecture	Darwin/amd64
Terminal	MacOS native Terminal
Go version	go1.16 darwin/amd64

[awesomehaze]

I'm getting this too on linux with konsole.

[SunnyRaj]

Tested on Windows using Windows Terminal running Powershell, and have the same problem.

[yellowsink]

Yep can reproduce on linux with kitty too. Will look into this.

[ghost]

reproducible on a tty, universal issue it seems

[yellowsink]

seems so, gonna start debugging now 👍

[yellowsink]

i think i have the issue actually: content is "" for some reason. Either the code calling ChatView.AddMessage() is wrong, or this needs a discordgo fork fix

[yellowsink]

Yes, appears to be issue in (my fork of?) discordgo, as the content is missing in the calling method too.

[yellowsink]

got it!

[yellowsink]

luckily /messages still works so I can use that :)

[yellowsink]

This has been fixed with a combination of gord-project/discordgo@ec47099 and https://github.com/cainy-a/gord/releases/tag/2021-05-06

It's a hacky fix, but it works well and doesnt add any real slowdown so cool I guess.

Will close once release is built.

[yellowsink]

OK it's fixed! 🎉 Check the latest release as linked above.

[awesomehaze]

Awesome!

[ghost]

looks like it's still happening sort of, now messages that were just sent render fine, but when I go into a channel, all messages sent while i wasn't in the channel (and sent after I opened gord) don't render, the rest do, but when the channel's open they all render fine

[ouwou]

i suspect if you omit the intents field completely when identifying with a user token this would be fixed

[awesomehaze]

I'm getting this issue again on the newest version.

[yellowsink]

Aw crap

[awesomehaze]

Confirmed that it happens for messages in channels that are not active. Switching to these channels shows messages without content.

[awesomehaze]

E.g. Channel 1 active, switch to channel 2. Message recieved on channel 1. Notification comes with message content, but switching to channel 1 doesn't show the message content.

[yellowsink]

Hmm ok maybe it only applies the workaround to get content when rendering not on fetching or something weird like that...

[awesomehaze]

Hmm ok maybe it only applies the workaround to get content when rendering not on fetching or something weird like that...

Any progress on this yet?

[yellowsink]

OK I've got the issue. The message object is fetched when the message is received, but it should be fetched on render - once you are in the correct channel.

Either that or my ChannelMessage function is broken.

[yellowsink]

ok yes the function in restapi.go in discordgo is dumb, I will fix ASAP.

[ghost]

just use assembly idiot lol

[yellowsink]

my bad lmao

[yellowsink]

ok turns out it was already fixed at discordgo master, i just forgot to tag it :\

[yellowsink]

ok it no longer errors but content is empty. Progress but still not ideal.

[yellowsink]

I defos have the content so thats odd

[yellowsink]

AWW YEAH FIXED IT

[yellowsink]

Now to make sure it works with caching

[yellowsink]

and it does POG

[yellowsink]

I can't believe that like 4 lines fixed that.

[yellowsink]

Here we go https://github.com/yellowsink/gord/releases/2021-06-16 epic

[dromer]

Nice! this was really starting to annoy me :P
(typically would close/reopen every time I saw new messages on a channel)

[yellowsink]

Yeah its nice to get such a problematic bug done with so i can focus on features (im thinking images :p )

[dromer]

Yeah its nice to get such a problematic bug done with so i can focus on features (im thinking images :p )

Lack of #21 is starting to bug me :P

[awesomehaze]

Yay!

[ghost]

ok uh whenever a reaction is added to a message that didn't already have any reactions this happens now

[yellowsink]

Huh that's odd. As in messages in the focused then unfocused state this originally occurred in? Or all messages?

[awesomehaze]

It's pretty random, but usually unfocused messages. It's still better than it was before

[yellowsink]

Hmm okay

[ghost]

Uh i only noticed it where a message that just had its first reaction added to it disappears

[yellowsink]

right... this sounds like itll be really specific if its this weird

[ghost]

ok even weirder, when you're in a channel, and then go to the guild selection box with Alt+S, then select a guild, but don't select a channel, then go back and select the same guild and channel you were in before, all messages that were not sent by you, and were sent after gord was opened, disappear

I have literally no clue why this specific scenario causes that, this is incredibly odd

[yellowsink]

What the...

[yellowsink]

OK that's weird