Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: gorakhargosh/watchdog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.0
Choose a base ref
...
head repository: gorakhargosh/watchdog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.0
Choose a head ref
  • 18 commits
  • 45 files changed
  • 5 contributors

Commits on Mar 20, 2023

  1. Bump the version

    @BoboTiG
    BoboTiG committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a4f28a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Use SPDX license identifier (#984) 

    Use SPDX license identifier: Apache-2.0
This will help tools to produce valid SPDX.

Signed-off-by: Marc-Etienne Vargenau <[email protected]>
    @vargenau
    vargenau authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2cdb2e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. [events] Log FileOpenedEvent, and FileClosedEvent, events in `Log… 

    …gingEventHandler`

Also enhanced events type annotations.
    @BoboTiG
    BoboTiG committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f3dfc4b View commit details
    Browse the repository at this point in the history

  2. [watchmedo] Log all events in LoggerTrick

    @BoboTiG
    BoboTiG committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d825a94 View commit details
    Browse the repository at this point in the history

  3. [tests] Improve FileSystemEvent coverage

    @BoboTiG
    BoboTiG committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    916af32 View commit details
    Browse the repository at this point in the history

  4. [tests] Skip test_unmount_watched_directory_filesystem() outside … 

    …the CI
    @BoboTiG
    BoboTiG committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    30a149a View commit details
    Browse the repository at this point in the history

  5. [watchmedo] Add missing import

    @BoboTiG
    BoboTiG committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f991928 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. [events] Use dataclass (#987) 

    * [events] Use `dataclass`

- [events] `FileSystemEvent`, and subclasses, are now `dataclass`es, and their `repr()` has changed
- [windows] `WinAPINativeEvent` is now a `dataclass`, and its `repr()` has changed

* chore: run black with line-lentgh=120
    @BoboTiG
    BoboTiG authored Apr 22, 2023
    Configuration menu
    Copy the full SHA
    41fca1e View commit details
    Browse the repository at this point in the history

  2. [windows] Remove the WATCHDOG_TRAVERSE_MOVED_DIR_DELAY hack (#986) 

    The `observers.read_directory_changes.WATCHDOG_TRAVERSE_MOVED_DIR_DELAY` hack was removed.
The constant will be kept to prevent breaking other softwares.
    @BoboTiG
    BoboTiG authored Apr 22, 2023
    Configuration menu
    Copy the full SHA
    363fe62 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Added event filter for the emitter (#989)

    @marioga
    marioga authored May 14, 2023
    Configuration menu
    Copy the full SHA
    48c49a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. doc: log the watched folder in the README (#995) 

    Related to #994.
    @abcdenis
    abcdenis authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    75a3289 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. feat: Add typing to dirsnapshot (#1012) 

    Before:

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●)
$ mypy --disallow-untyped-defs src/watchdog/utils/dirsnapshot.py
src/watchdog/utils/dirsnapshot.py:82: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:88: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:93: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:141: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:144: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:162: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:167: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:172: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:177: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:187: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:194: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:204: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:211: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:241: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:258: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:290: error: Function is missing a return type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:296: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:302: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:307: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:310: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:313: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:316: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:331: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:340: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:343: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:354: error: Function is missing a type annotation  [no-untyped-def]
src/watchdog/utils/dirsnapshot.py:364: error: Function is missing a return type annotation  [no-untyped-def]
Found 27 errors in 1 file (checked 1 source file)
```

After:

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●●)
$ mypy --disallow-untyped-defs src/watchdog/utils/dirsnapshot.py
Success: no issues found in 1 source file
```
    @msabramo
    msabramo authored Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5f9d93c View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. fix: mypy errors introduced by #1012 (#1014)

    @msabramo
    msabramo authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2338837 View commit details
    Browse the repository at this point in the history

  2. feat: Add DirectorySnapshotDiff.ContextManager (#1011) 

    * Add DirectorySnapshotDiff.ContextManager

A context manager that creates two directory snapshots and a diff object
that represents the difference between the two snapshots.

```python
dir_snapshot_diff_context_manager = DirectorySnapshotDiff.ContextManager("some_path")
with dir_snapshot_diff_context_manager:
    # Do some things that change files...
    ...

print(dir_snapshot_diff_context_manager.diff.files_created)
print(dir_snapshot_diff_context_manager.diff.files_deleted)
```

* Add entry to changelog.rst

* Add typing to ContextManager.__init__
    @msabramo
    msabramo authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    52d8692 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. style: run black & isort on inotify (#1015) 

    * Run black on inotify

Run `black` on `src/watchdog/observers/inotify.py`. Fixes failing
`flake8` tests:

Before:
-------

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●)
$ python -m tox -e flake8
flake8: install_deps> python -I -m pip install -r requirements-tests.txt
.pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
flake8: install_package_deps> python -I -m pip install 'PyYAML>=3.10'
flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/12/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
flake8: commands[0]> python -m flake8 docs tools src tests setup.py
src/watchdog/observers/inotify.py:224:86: W504 line break after binary operator
src/watchdog/observers/inotify.py:225:88: W504 line break after binary operator
flake8: exit 1 (0.40 seconds) /Users/abramowi/Code/OpenSource/watchdog> python -m flake8 docs tools src tests setup.py pid=76654
.pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  flake8: FAIL code 1 (9.23=setup[8.83]+cmd[0.40] seconds)
  evaluation failed :( (10.10 seconds)
```

After:
------

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●)
$ python -m tox -e flake8
.pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/13/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
flake8: commands[0]> python -m flake8 docs tools src tests setup.py
.pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  flake8: OK (1.59=setup[1.11]+cmd[0.48] seconds)
  congratulations :) (2.45 seconds)
```

* Create pyproject.toml

* Run black again

* Run isort

---------

Co-authored-by: Mickaël Schoentgen <[email protected]>
    @msabramo @BoboTiG
    msabramo and BoboTiG authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e4e2f8e View commit details
    Browse the repository at this point in the history

  2. fix: mypy "type: ignore" comment errors (#1016) 

    Before:
-------

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master)
$ python -m tox -e mypy
.pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/27/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
mypy: commands[0]> mypy
src/watchdog/observers/fsevents2.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
src/watchdog/observers/fsevents2.py:33: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
src/watchdog/observers/fsevents.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
tests/test_fsevents.py:19: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
tests/test_skip_repeats_queue.py:109: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
Found 5 errors in 4 files (checked 48 source files)
mypy: exit 1 (0.63 seconds) /Users/abramowi/Code/OpenSource/watchdog> mypy pid=24917
.pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  mypy: FAIL code 1 (1.67=setup[1.04]+cmd[0.63] seconds)
  evaluation failed :( (2.49 seconds)
```

After:
------

```
(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (fix-mypy-type-ignore-import-errors)
$ python -m tox -e mypy
.pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
.pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
mypy: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/28/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl
mypy: commands[0]> mypy
Success: no issues found in 48 source files
.pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  mypy: OK (1.67=setup[1.05]+cmd[0.62] seconds)
  congratulations :) (2.44 seconds)
```
    @msabramo
    msabramo authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6cfe9cc View commit details
    Browse the repository at this point in the history

  3. chore: Update supported Python versions (drop 3.7, add 3.12) (#1017) 

    * tox.ini: Update supported versions

as described at https://devguide.python.org/versions/

Fixes: GH-971

* Update more stuff to say 3.8+ instead of 3.7+

* tox.ini: Remove py312

It seems tox doesn't support it yet.

* .github/workflows/tests.yml: Remove "3.7"

* Revert "tox.ini: Remove py312"

This reverts commit 75c3edf.

* .github/workflows/tests.yml: Add "3.12"

* Update changelog.rst

---------

Co-authored-by: Mickaël Schoentgen <[email protected]>
    @msabramo @BoboTiG
    msabramo and BoboTiG authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6cdf07e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Version 4.0.0

    @BoboTiG
    BoboTiG committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7d651ac View commit details
    Browse the repository at this point in the history
Loading