Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type are only exported from sub-modules #325

Closed
avin-kavish opened this issue Feb 15, 2020 · 2 comments · Fixed by #375
Closed

Type are only exported from sub-modules #325

avin-kavish opened this issue Feb 15, 2020 · 2 comments · Fixed by #375
Labels
help wanted We'd love to have community involvement on this issue. priority: p3 Desirable enhancement or fix. May not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@avin-kavish
Copy link
Contributor

Types are imported from sub-folders as follows,

import {Client} from "@googlemaps/google-maps-services-js";
import { PlaceAutocompleteResponse } from '@googlemaps/google-maps-services-js/dist'
import { PlaceAutocompleteType } from '@googlemaps/google-maps-services-js/dist/places/autocomplete'

Better export all of them from index.ts
@avin-kavish avin-kavish added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 15, 2020
@jpoehnelt jpoehnelt added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Feb 28, 2020
@jpoehnelt
Copy link
Contributor

jpoehnelt commented Feb 28, 2020 •
edited
Loading

mind submitting a pr?

@jpoehnelt jpoehnelt added the help wanted We'd love to have community involvement on this issue. label Feb 28, 2020
@jpoehnelt jpoehnelt added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Mar 12, 2020
@jpoehnelt jpoehnelt mentioned this issue Mar 26, 2020
Merged
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andreialecu andreialecu mentioned this issue Jul 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We'd love to have community involvement on this issue. priority: p3 Desirable enhancement or fix. May not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: export types at root googlemaps/google-maps-services-js
3 participants
@jpoehnelt @avin-kavish @googlemaps-bot