Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some info logs logged from sidecar when sdkServer.logLevel set to Error #3629

Closed
steven-supersolid opened this issue Feb 2, 2024 · 0 comments · Fixed by #3631
Closed

Some info logs logged from sidecar when sdkServer.logLevel set to Error #3629

steven-supersolid opened this issue Feb 2, 2024 · 0 comments · Fixed by #3631
Assignees
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.

Comments

@steven-supersolid
Copy link
Collaborator

What happened:
With sdkServer.logLevel set to Error sidecar logs are still visible such as

Starting sdk sidecar

And

Starting SDKServer grpc service...

What you expected to happen:
To see only error logs from the sidecar

How to reproduce it (as minimally and precisely as possible):

  1. Set sdkServer.logLevel to Error via manifest entry
  2. Start a gs
  3. View logs and note that some info level logs are present

Anything else we need to know?:
One log originates here https://github.com/googleforgames/agones/blob/main/cmd/sdk-server/main.go#L231
Another log originates here https://github.com/googleforgames/agones/blob/main/cmd/sdk-server/main.go#L75

These are triggered before logging is configured.

@markmandel posted that logging is configured here https://github.com/googleforgames/agones/blob/5f58fce4c00f97ef012db8f8a503898a4725d11b/pkg/sdkserver/sdkserver.go#L249C1-L261C3

Suggestion from Mark

Off the top of my head, I can't see any reason we couldn't make the log level an environment / arg on the sidecar pod instead, and have it be global

Environment:

  • Agones version: 1.32
  • Kubernetes version (use kubectl version): 1.26
  • Cloud provider or hardware configuration: GKE
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s):
  • Others:
@steven-supersolid steven-supersolid added the kind/bug These are bugs. label Feb 2, 2024
@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants