Adding Config options to workbox-sw setConfig() #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
Mar 1, 2018
packages/workbox-sw/_types.mjs
Outdated
| */ | ||
|
|
||
| /** | ||
| * @typedef {Object} ManifestEntry |
There was a problem hiding this comment.
Defining ManifestEntry here doesn't look right.
packages/workbox-sw/_types.mjs
Outdated
| * @property {String} revision The revision details for the file. This is a | ||
| * hash generated by node based on the file contents. | ||
| * | ||
| * @memberof module:workbox-build |
There was a problem hiding this comment.
module:workbox-sw (or maybe module:workbox, if it's supposed to match the namespace?)
added 2 commits
March 1, 2018 10:04
|
Yeah you are right - sorry this is totally wrong. Just did another pass and found some errors in other spots that I fixed up |
jeffposnick
approved these changes
Mar 1, 2018
PR-Bot Size PluginChanged File SizesNo file sizes have changed. New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 155% of our max size budget. Total Size: 22.7KB Gzipped: 9.1KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1333