-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report: avoid paint storms on scrolly header #5207
Conversation
</g> | ||
<g mask="url(#b)" fill="#FFF"> | ||
<g transform="translate(96 86)"> | ||
<circle cx="87.5" cy=".5" r="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text-align: right; | ||
transform-origin: bottom right; | ||
will-change: opacity; /* opacity is changed on scroll */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the score scales look fine with this now, how are you supposed to tell when the text will be messed up by this?
animation: panacross 30s linear infinite; | ||
animation-play-state: paused; | ||
} | ||
.lh-header-sticky:hover .lh-lighthouse__clouds { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the :hover
threw me for a while since the hitbox includes the dropdown of the scores, how much do you like the hover effect vs. always? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally ok with always, too :)
Something something lighthouse is always looking out for you metaphor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wfm, animation is great! can't wait to multiply those clouds :D
☁️ ☁️ ☁️ ☁️ ☁️ ☁️ ☁️ ☁️ ☁️ ☁️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with blurry URL fix
👍 👍 on the var renames, too
animation: panacross 30s linear infinite; | ||
animation-play-state: paused; | ||
} | ||
.lh-header-sticky:hover .lh-lighthouse__clouds { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally ok with always, too :)
Something something lighthouse is always looking out for you metaphor
whats the deal |
5ff7c89
to
f6a061f
Compare
And animate the clouds on hover
Here's the diff on the paint storms. Before and after:
Check out the deployment to try the animated clouds.