core: add type checking to connection #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Mar 12, 2018
| @@ -28,7 +28,7 @@ class ReportScoring { | |||
| /** | |||
| * Returns the report JSON object with computed scores. | |||
| * @param {{categories: !Object<string, {id: string|undefined, weight: number|undefined, audits: !Array<{id: string, weight: number|undefined}>}>}} config | |||
| * @param {!Object<{score: ?number|boolean|undefined}>} resultsByAuditId | |||
| * @param {!Object<string, {score: ?number|boolean|undefined, notApplicable: boolean, informative: boolean}>} resultsByAuditId | |||
There was a problem hiding this comment.
not sure why this wasn't failing before. Possibly from the update to ts 2.7.2?
| // first, we activate it to a foreground tab, then we connect | ||
| return this._runJsonCommand(`activate/${firstTab.id}`) | ||
| .then(_ => this._connectToSocket(firstTab)); | ||
| .then(() => this._connectToSocket(firstTab)); |
patrickhulce
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no significant changes, mostly typings (e.g.
runJsonCommandreturns an object, not a string).The biggest shifts were just e.g. assuring the compiler we wouldn't emit events after the event emitter was disposed.
For the future, there are a lot of opportunities for better typing on these methods that take a string but return a bunch of different things via TS's conditional types (or plain overloading with string literal arguments)