report(description): update helpText for document.title audit #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the audit occurs in both the a11y and SEO categories, the new helpText now mentions both. The helpText links to a new reference on d.g.c/web that discusses both the a11y and SEO aspects of the audit. The old aXe doc previously linked to only mentioned the a11y side.
|
LGTM 👍 |
rviscomi
approved these changes
Mar 2, 2018
paulirish
approved these changes
Mar 2, 2018
paulirish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the audit occurs in both the a11y and SEO categories, the new helpText now mentions both. The helpText links to a new reference on d.g.c/web that discusses both the a11y and SEO aspects of the audit. The previously-linked-to aXe doc only mentioned the a11y side. But that aXe doc is itself mentioned in the new reference. I also updated the failureDescription while I was here, since we agreed in group chat that contractions are more in-tune with the Lighthouse voice.
#polish