-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reading from the request stream #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 67.82% 68.01% +0.18%
==========================================
Files 1 1
Lines 345 347 +2
Branches 28 28
==========================================
+ Hits 234 236 +2
Misses 110 110
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage ? 68.01%
=========================================
Files ? 1
Lines ? 347
Branches ? 28
=========================================
Hits ? 236
Misses ? 110
Partials ? 1
Continue to review full report at Codecov.
|
}); | ||
res.body | ||
.on('error', err => { | ||
console.log('whoa there was an error, passing it on: ' + err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! That console.log
shouldn't be there. Can you remove this while you're in there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally can! Though I am noticing there are 3 different logs in the code, 1 of which appears to happen in lieu of error handling 😱 We might just want to open a separate PR to remove all them and implement error handling?
No description provided.