Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reading from the request stream #67

Merged
merged 2 commits into from
Aug 7, 2019
Merged

feat: support reading from the request stream #67

merged 2 commits into from
Aug 7, 2019

Conversation

callmehiphop
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #67 into master will increase coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   67.82%   68.01%   +0.18%     
==========================================
  Files           1        1              
  Lines         345      347       +2     
  Branches       28       28              
==========================================
+ Hits          234      236       +2     
  Misses        110      110              
  Partials        1        1
Impacted Files Coverage Δ
src/index.ts 68.01% <66.66%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4a6df...262e5ff. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@12901a0). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   68.01%           
=========================================
  Files             ?        1           
  Lines             ?      347           
  Branches          ?       28           
=========================================
  Hits              ?      236           
  Misses            ?      110           
  Partials          ?        1
Impacted Files Coverage Δ
src/index.ts 68.01% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12901a0...5b53350. Read the comment docs.

});
res.body
.on('error', err => {
console.log('whoa there was an error, passing it on: ' + err);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! That console.log shouldn't be there. Can you remove this while you're in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally can! Though I am noticing there are 3 different logs in the code, 1 of which appears to happen in lieu of error handling 😱 We might just want to open a separate PR to remove all them and implement error handling?

@JustinBeckwith JustinBeckwith merged commit ae23054 into googleapis:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants