-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update dependencies check to only check for runtime and compile scopes #678
Merged
SurferJeffAtGoogle
merged 9 commits into
googleapis:master
from
salehsquared:dependencies-check
Aug 6, 2020
Merged
build: update dependencies check to only check for runtime and compile scopes #678
SurferJeffAtGoogle
merged 9 commits into
googleapis:master
from
salehsquared:dependencies-check
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should be renamed to be update both subject and commit msg. To update commit msg run |
stephaniewang526
approved these changes
Jul 21, 2020
@saturnism @elharo this is for verifying flattened pom vs. original pom completeness |
chingor13
approved these changes
Jul 22, 2020
saturnism
reviewed
Jul 22, 2020
@chingor13 could you merge this one please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the dependencies.sh kokoro script to only compare 'compile' and 'runtime' scoped dependencies between the flattened POM and original POM.
This follows an issue recently noted within the java-bigquerystorage libraries in which inconsistent behavior with 'provided' scope transitive dependencies.