Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: integration/sample tests should set GOOGLE_CLOUD_PROJECT #483

Closed
chingor13 opened this issue Apr 10, 2020 · 0 comments · Fixed by #484
Closed

Java: integration/sample tests should set GOOGLE_CLOUD_PROJECT #483

chingor13 opened this issue Apr 10, 2020 · 0 comments · Fixed by #484
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

We're currently setting GCLOUD_PROJECT which should be deprecated.
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 10, 2020
@chingor13 chingor13 self-assigned this Apr 10, 2020
This was referenced Apr 10, 2020
Merged
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(java): set GOOGLE_CLOUD_PROJECT env for samples/integration tests chingor13/synthtool
2 participants
@chingor13 @yoshi-automation