Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

feat: adding sofia to sloth users.json #378

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Oct 29, 2019

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
users.json Outdated
@@ -85,7 +85,8 @@
"tswast",
"vishald123",
"AlisskaPie",
"tritone"
"tritone",
"sofisl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a linter so that this would be caught automatically (perhaps something like this, but mind tabbing sofisl in a couple more characters so it matches the spacing of tritone; this is the sort of nit I usually try to not make in code review, please forgive me 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! I can make a new PR, it's good practice!

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind also adding yourself to the Node.js team, the users list under yoshi-nodejs, after the repos.

@bcoe bcoe merged commit 2ccff70 into googleapis:master Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants