canUseDirectPath returning false when DirectPath is enabled #3134
Assignees
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
blakeli0
added
type: bug
ldetmer
pushed a commit
that referenced
this issue
Sep 17, 2024
…#3170) This should fix #3134. Spanner needs to know if `GrpcSpannerStub`’s transportChannel uses DirectPath for tracing purposes. `canUseDirectPath()` from `stubSettings.getTransportChannelProvider()` does not provide accurate information because credentials are set afterwards when creating the transportChannel for `GrpcSpannerStub` (`GrpcSpannerStub.create(stubSettings)`) Proposed change: Expose a property in `GrpcTransportChannel` and pass this information down from channel provider. Spanner can access from `ClientContext` as shown below ``` SpannerStubSettings stubSettings = options .getSpannerStubSettings() .toBuilder() .setTransportChannelProvider(channelProvider) .setCredentialsProvider(credentialsProvider) .setStreamWatchdogProvider(watchdogProvider) .setTracerFactory(options.getApiTracerFactory()) .build(); ClientContext clientContext = ClientContext.create(stubSettings); // create GrpcSpannerStub from clientContext instead. // this is equivelant to GrpcSpannerStub.create(stubSettings) this.spannerStub = GrpcSpannerStub.create(clientContext); // access this property from transport channel. ((GrpcTransportChannel) clientContext.getTransportChannel()).isDirectPath(); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Spanner Client library is trying to use canUseDirectPath from the GapicSpannerRPC class
This method is always returning
falseirrespective of the DirectPath is enabled or not.It is because of the needsCredentials which always returns "true" as credentials are always null.
Same method is working for gax because the credentials are set in ClientContext before the transportChannel is created.
However for Spanner library there is no way to use the
canUseDirectPathmethod as the actual channel provider never gets updated.The text was updated successfully, but these errors were encountered: