Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Endpoint resolution uses user set endpoint from ClientSettings #2429

Merged
merged 5 commits into from
Jan 29, 2024
Merged

fix: Endpoint resolution uses user set endpoint from ClientSettings #2429

merged 5 commits into from
Jan 29, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jan 26, 2024

Add new Internal method getUserSetEndpoint() that returns the user set endpoint from ClientSettings or null otherwise.

This is used as part of endpoint resolution to determine the proper endpoint.

@lqiu96 lqiu96 requested a review from blakeli0 January 26, 2024 22:07
@lqiu96 lqiu96 requested a review from a team as a code owner January 26, 2024 22:07
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

blakeli0
blakeli0 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once we have getters for resolvedEndpoint, we should add more unit test cases.

@lqiu96 lqiu96 merged commit 46b0a85 into main Jan 29, 2024
38 of 39 checks passed
@lqiu96 lqiu96 deleted the fix-user-set-endpoint branch January 29, 2024 18:47
@release-please release-please bot mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @blakeli0