Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The count of outstanding RPCs in ChannelPool could go negative. #2081

Closed
blakeli0 opened this issue Oct 9, 2023 · 3 comments · Fixed by #2185
Closed

The count of outstanding RPCs in ChannelPool could go negative. #2081

blakeli0 opened this issue Oct 9, 2023 · 3 comments · Fixed by #2185
Assignees
@blakeli0
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Oct 9, 2023

The count of outstanding RPCs in ChannelPool could go negative in some cases, and an exception would be throw. In such case, there is no way a customer could recover from such error. See internal issue for details.

We need to prevent the count of outstanding RPCs to go negative and also figure out why this happened.
@blakeli0 blakeli0 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 9, 2023
@blakeli0 blakeli0 mentioned this issue Oct 9, 2023
Closed
4 tasks
@meltsufin
Copy link
Member

Do we understand how this could happen and are we able to reproduce the error?
cc: @igorbernstein2

@blakeli0
Copy link
Collaborator Author

blakeli0 commented Oct 9, 2023

Do we understand how this could happen and are we able to reproduce the error? cc: @igorbernstein2

I don't think we understand how this could happen, @igorbernstein2 tried to add the stacktrace so we might be able to figure it out next time it happens. This is not reproducible either by customers, we might be able to reproduce it by digging really deep into the codebase.

@meltsufin
Copy link
Member

In the internal bug I see some ideas. Can we try to reproduce them?

@blakeli0 blakeli0 mentioned this issue Oct 19, 2023
Merged
@blakeli0 blakeli0 self-assigned this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakeli0 blakeli0

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@blakeli0 @meltsufin