Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter *.legacy.yaml when parsing java_gapic_opt from proto_path #2014

Closed
JoeWang1127 opened this issue Sep 20, 2023 · 0 comments · Fixed by #2015
Closed

Filter *.legacy.yaml when parsing java_gapic_opt from proto_path #2014

JoeWang1127 opened this issue Sep 20, 2023 · 0 comments · Fixed by #2015
Assignees
@JoeWang1127
Labels
hermetic-build priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

When generating from google/cloud/videointelligence/v1, the api-service-config is set to google/cloud/videointelligence/v1/videointelligence_gapic.legacy.yaml, rather than google/cloud/videointelligence/v1/videointelligence_v1.yaml.

We should rewrite the parsing logic to filter out *.legacy.yaml.

The full diff: https://paste.googleplex.com/4992719838511104
@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. hermetic-build labels Sep 20, 2023
@JoeWang1127 JoeWang1127 self-assigned this Sep 20, 2023
@JoeWang1127 JoeWang1127 mentioned this issue Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeWang1127 JoeWang1127

Labels
hermetic-build priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: filter out *gapic.legacy.yaml when parsing java_gapic_opts googleapis/sdk-platform-java
1 participant
@JoeWang1127