From b208bc2665ccccf98c34e3396d5c2398690d187b Mon Sep 17 00:00:00 2001 From: Benjamin Coe Date: Tue, 4 Feb 2020 14:32:45 -0800 Subject: [PATCH 1/3] build: codecov was finding the wrong JSON files --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b81e55ffde4..8c7e9b0c351 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,7 +42,7 @@ jobs: - run: npm install - run: npm test - run: npm i codecov - - run: ./node_modules/.bin/codecov + - run: ./node_modules/.bin/c8 report --reporter=text-lcov | ./node_modules/.bin/codecov --pipe - uses: codecov/codecov-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} From 829992763d4c01011338485a019aa747ccfe382e Mon Sep 17 00:00:00 2001 From: Benjamin Coe Date: Tue, 4 Feb 2020 14:41:10 -0800 Subject: [PATCH 2/3] chore: working on getting codecov working --- .github/workflows/ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8c7e9b0c351..401c682eeee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,7 +42,4 @@ jobs: - run: npm install - run: npm test - run: npm i codecov - - run: ./node_modules/.bin/c8 report --reporter=text-lcov | ./node_modules/.bin/codecov --pipe - - uses: codecov/codecov-action@v1 - with: - token: ${{ secrets.CODECOV_TOKEN }} + - run: ./node_modules/.bin/c8 report --reporter=text-lcov | ./node_modules/.bin/codecov -t ${{ secrets.CODECOV_TOKEN }} --pipe From aab65c969cb3b81876db9fd76c51d1e9f2b3652f Mon Sep 17 00:00:00 2001 From: bcoe Date: Wed, 5 Feb 2020 10:40:42 -0800 Subject: [PATCH 3/3] chore: address code review --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 401c682eeee..99f4fd3998c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,5 +41,4 @@ jobs: node-version: 12 - run: npm install - run: npm test - - run: npm i codecov - - run: ./node_modules/.bin/c8 report --reporter=text-lcov | ./node_modules/.bin/codecov -t ${{ secrets.CODECOV_TOKEN }} --pipe + - run: ./node_modules/.bin/c8 report --reporter=text-lcov | npx codecov@3 -t ${{ secrets.CODECOV_TOKEN }} --pipe