Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom logger interface #884

Merged
merged 6 commits into from
May 4, 2021

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Apr 24, 2021

  • Add a CheckpointLogger which outputs similar output to the checkpoint function.

Fixes #883

Add a CheckpointLogger which outputs similar output to the checkpoint
function.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2021
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #884 (8f3ee3e) into master (e3535c6) will increase coverage by 0.08%.
The diff coverage is 84.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   94.29%   94.37%   +0.08%     
==========================================
  Files          71       72       +1     
  Lines        9707     9693      -14     
  Branches      974     1031      +57     
==========================================
- Hits         9153     9148       -5     
+ Misses        551      542       -9     
  Partials        3        3              
Impacted Files Coverage Δ
src/util/checkpoint.ts 79.41% <16.66%> (-12.02%) ⬇️
src/releasers/ruby-yoshi.ts 27.37% <25.00%> (+0.59%) ⬆️
src/releasers/go-yoshi.ts 93.26% <33.33%> (+0.48%) ⬆️
src/releasers/php-yoshi.ts 94.18% <50.00%> (+1.08%) ⬆️
src/releasers/java-yoshi.ts 90.90% <66.66%> (+0.13%) ⬆️
src/releasers/rust.ts 94.24% <66.66%> (+0.28%) ⬆️
src/updaters/php-manifest.ts 92.42% <66.66%> (+3.53%) ⬆️
src/updaters/root-composer.ts 90.90% <75.00%> (+4.46%) ⬆️
src/github.ts 90.24% <85.18%> (+0.04%) ⬆️
src/updaters/rust/cargo-toml.ts 99.24% <90.90%> (-0.04%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3535c6...8f3ee3e. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, as soon as you're ready to turn it into a PR.

@chingor13 chingor13 marked this pull request as ready for review May 4, 2021 21:28
@chingor13 chingor13 requested a review from a team May 4, 2021 21:28
@chingor13 chingor13 requested a review from a team as a code owner May 4, 2021 21:28
@chingor13 chingor13 merged commit 74ac982 into googleapis:master May 4, 2021
@chingor13 chingor13 deleted the custom-logger branch May 4, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide injectable logger interface
2 participants