Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Java replacer should handle -sp.1 version replacements #874

Merged
merged 5 commits into from
Apr 23, 2021

Conversation

chingor13
Copy link
Contributor

Fixes #873

@chingor13 chingor13 requested a review from a team April 23, 2021 00:13
@chingor13 chingor13 requested a review from a team as a code owner April 23, 2021 00:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #874 (d571c17) into master (174ab2e) will increase coverage by 0.16%.
The diff coverage is 93.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   94.07%   94.24%   +0.16%     
==========================================
  Files          68       69       +1     
  Lines        9809     9607     -202     
  Branches     1014      971      -43     
==========================================
- Hits         9228     9054     -174     
+ Misses        578      550      -28     
  Partials        3        3              
Impacted Files Coverage Δ
src/release-pr.ts 93.73% <81.48%> (-0.78%) ⬇️
src/releasers/java/version.ts 94.35% <90.00%> (-2.23%) ⬇️
src/github.ts 90.20% <100.00%> (+0.06%) ⬆️
src/plugins/node-workspace.ts 100.00% <100.00%> (ø)
src/releasers/helm.ts 97.56% <100.00%> (+5.19%) ⬆️
src/releasers/java-lts.ts 100.00% <100.00%> (ø)
src/releasers/java-yoshi.ts 90.76% <100.00%> (ø)
src/releasers/java/bump_type.ts 81.81% <100.00%> (+2.87%) ⬆️
src/releasers/node.ts 100.00% <100.00%> (ø)
src/releasers/ocaml.ts 100.00% <100.00%> (+5.79%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d0c13...d571c17. Read the comment docs.

@chingor13 chingor13 requested a review from bcoe April 23, 2021 17:10
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 81131e5 into googleapis:master Apr 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java: incorrect version replacements for sp releases
2 participants