fix(manifest): package paths sharing same prefix being shadowed in commit-split #848
Conversation
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 64 64
Lines 9203 9203
Branches 988 988
=======================================
Hits 8630 8630
Misses 570 570
Partials 3 3
Continue to review full report at Codecov.
|
src/commit-split.ts
Outdated
| @@ -96,7 +96,7 @@ export class CommitSplit { | |||
| let pkgName; | |||
| if (this.packagePaths) { | |||
| // only track paths under this.packagePaths | |||
| pkgName = this.packagePaths.find(p => file.indexOf(p) === 0); | |||
| pkgName = this.packagePaths.find(p => file.indexOf(p + '/') === 0); | |||
There was a problem hiding this comment.
nit, would you mind making this: `${p}/`
| const fooBarCommit = buildMockCommit('fix(foobar): fix foobar', [ | ||
| fooBarPath + '/foobar.ts', | ||
| ]); | ||
| const foobarCommit = buildMockCommit('fix(foo+bar): fix foo+bar', [ |
There was a problem hiding this comment.
same here, would you mind making these backticks?
joeldodge79
force-pushed
the
commit-split-bugfix-again
branch
from
017fb8e to
2c5da6d
Compare
bcoe
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
No description provided.