fix: associated pull requests should match merge commit sha #817
Conversation
…pull request for a commit
…ha matches the commit sha
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 64 64
Lines 8870 8880 +10
Branches 930 883 -47
=======================================
+ Hits 8299 8309 +10
Misses 568 568
Partials 3 3
Continue to review full report at Codecov.
|
|
cc @kolea2 |
| const pullRequest = graphCommit.associatedPullRequests.nodes.find( | ||
| pr => { | ||
| return pr.mergeCommit && pr.mergeCommit.oid === graphCommit.sha; | ||
| } | ||
| ); | ||
| if (pullRequest) { |
There was a problem hiding this comment.
makes sense though I'd be curious to understand better what a pr.mergeCommit.oid is in different cases of how the PR could have been merged (e.g. traditional "create a merge commit", vs "squash", vs "rebase"). I guess whatever the PR-Merge strategy, this logic will find the PR that literally is the reason for this graphCommit.sha/pr.mergeCommit.oid to exist in the history of the branch at all.
This should fix some misidentified release PRs. Sometimes, multiple pull requests are associated with a commit. In those cases, match the merge commit sha against the commit sha to find the pull request that made that commit.
Fixes #818